ascherbakoff commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1853454070
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1107,7 +1116,7 @@ public CompletableFuture<Void> upsert(BinaryRowEx row,
@Nullable InternalTransac
.transactionId(txo.id())
.enlistmentConsistencyToken(enlistmentConsistencyToken)
.requestType(RW_UPSERT)
- .timestamp(clockService.now())
+ .timestamp(txo.startTimestamp()) // TODO
https://issues.apache.org/jira/browse/IGNITE-23712
Review Comment:
This is intended change and doesn't break txn ordering guaranties.
At txn map phase we need to sync with remote clocks to calculate proper
commit timestamp, so sending ts value doesn't matter.
hlc.current can used as well, but it involves more overhead.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/UpsertKvBenchmark.java:
##########
@@ -66,6 +66,13 @@ public class UpsertKvBenchmark extends
AbstractMultiNodeBenchmark {
@Param({"8"})
private int partitionCount;
+ private static final AtomicInteger counter = new AtomicInteger();
Review Comment:
🆗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]