rpuch commented on code in PR #4825:
URL: https://github.com/apache/ignite-3/pull/4825#discussion_r1869034069
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageWriteHandler.java:
##########
@@ -163,18 +161,17 @@ private void
handleNonCachedWriteCommand(CommandClosure<WriteCommand> clo) {
} else {
assert false : "Command was not found [cmd=" + command + ']';
}
- } catch (IgniteInternalException e) {
- clo.result(e);
- } catch (CompletionException e) {
- clo.result(e.getCause());
- } catch (Throwable t) {
+ } catch (Throwable e) {
Review Comment:
Current `e` seems to be ok as it stands for 'exception' which is, in most
cases, a synonym for 'throwable', so I would prefer to leave it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
