sanpwc commented on code in PR #4446:
URL: https://github.com/apache/ignite-3/pull/4446#discussion_r1871865524
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -1298,6 +1323,79 @@ private CompletableFuture<Boolean>
onPrimaryExpired(PrimaryReplicaEventParameter
return falseCompletedFuture();
}
+ // TODO: move to Replica
https://issues.apache.org/jira/browse/IGNITE-23750
+ private void registerFailoverCallback(ReplicationGroupId
replicationGroupId) {
+ CompletableFuture<Replica> replicaFuture =
replicaManager.replica(replicationGroupId);
Review Comment:
Is it possible to get !null replicaManager.replica(replicationGroupId) that
won't be completed? In other words:
is `assert replicaFuture == null || replicaFuture.isDone` valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
