sanpwc commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884194321
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -447,6 +447,10 @@ public boolean startRaftNode(
// Thread pools are shared by all raft groups.
NodeOptions nodeOptions = opts.copy();
+ // Then a new election starts on a node, it has local physical
time higher than last generated safe ts
+ // because we wait out the clock skew.
+
nodeOptions.setElectionTimeoutMs(Math.max(nodeOptions.getElectionTimeoutMs(),
groupOptions.maxClockSkew()));
Review Comment:
How are you going to guarantee `it has local physical time higher than last
generated safe ts` in case of immediate leader election?
E.g. if there is only one node in partition. (let's say that partition was
rebalanced from A to B)
I'm not sure whether it's the only case of immediate leader election
attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
