korlov42 commented on code in PR #4959:
URL: https://github.com/apache/ignite-3/pull/4959#discussion_r1898365431
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorsFactory.java:
##########
@@ -267,11 +265,13 @@ private final class AccumulatorWrapperImpl implements
AccumulatorWrapper<RowT> {
private final boolean distinct;
AccumulatorWrapperImpl(
+ RowHandler<RowT> handler,
Review Comment:
good point, fixed
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorsFactory.java:
##########
@@ -57,7 +57,7 @@
* AccumulatorsFactory.
* TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
*/
-public class AccumulatorsFactory<RowT> implements
Supplier<List<AccumulatorWrapper<RowT>>> {
+public class AccumulatorsFactory<RowT> {
Review Comment:
javadoc updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
