AMashenkov commented on code in PR #5004:
URL: https://github.com/apache/ignite-3/pull/5004#discussion_r1905726441
##########
modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedChannelRegistry.java:
##########
@@ -35,73 +34,57 @@
import org.apache.ignite.internal.eventlog.config.schema.ChannelView;
import org.apache.ignite.internal.eventlog.config.schema.EventLogConfiguration;
-class ConfigurationBasedChannelRegistry implements ChannelRegistry {
- private final ReadWriteLock guard;
+public class ConfigurationBasedChannelRegistry implements ChannelRegistry {
+ private final AtomicReference<Map<String, EventChannel>> cache;
- private final Map<String, EventChannel> cache;
-
- private final Map<String, Set<EventChannel>> typeCache;
+ private final AtomicReference<Map<String, Set<EventChannel>>> typeCache;
Review Comment:
No AtomicReference is needed.
These can be plain volatile fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
