ygerzhedovich commented on code in PR #4991:
URL: https://github.com/apache/ignite-3/pull/4991#discussion_r1905749162
##########
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -73,13 +104,36 @@ public static synchronized ErrorGroup registerGroup(String
groupName, short grou
}
}
- ErrorGroup newGroup = new ErrorGroup(grpName, groupCode);
+ if (REGISTERED_ERROR_PREFIXES.add(errorPrefix)) {
+ String errorPrefixes = String.join("|", REGISTERED_ERROR_PREFIXES);
+ String pattern =
EXCEPTION_MESSAGE_STRING_PATTERN.replace(PLACEHOLDER, errorPrefixes);
+ EXCEPTION_MESSAGE_PATTERN = Pattern.compile(pattern, DOTALL);
Review Comment:
What does mean `every time`? Just once per each a new error prefix. I don't
see benefits for moving it from start node to the first use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
