Cyrill commented on code in PR #5012:
URL: https://github.com/apache/ignite-3/pull/5012#discussion_r1910262749
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1161,13 +1165,21 @@ private CompletableFuture<Void>
startLocalPartitionsAndClients(
boolean shouldStartPartition;
if (isRecovery) {
- // The condition to start the replica is
- // `pending.contains(node) || (stable.contains(node) &&
!pending.isForce())`.
- // However we check only the right part of this condition
here
- // since after `startTables` we have a call to
`processAssignmentsOnRecovery`,
- // which executes pending assignments update and will
start required partitions there.
- shouldStartPartition = localMemberAssignmentInStable !=
null
- && (pendingAssignments == null ||
!pendingAssignments.force());
+ AssignmentsChain assignmentsChain =
assignmentsChains.get(i);
+
+ if (assignmentsChain == null ||
assignmentsChain.chain().size() == 1) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]