JAkutenshi commented on code in PR #5015:
URL: https://github.com/apache/ignite-3/pull/5015#discussion_r1910721869
##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLogger.java:
##########
@@ -25,12 +25,16 @@
/**
* {@link IgniteLogger} throttle.
*
- * <p>Messages are logged only if they were not logged for the last {@link
#THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
- * messages are checked for duplicates, but also exception classes if
present.</p>
+ * <p>Messages are logged only if they were not logged recently. The interval
of message appears is {@link this#DEFAULT_THROTTLE_TIMEOUT}
+ * by default or can be configured through the JVM property {@link
this#THROTTLE_TIMEOUT_MILLIS}.
+ * Note that not only error messages are checked for duplicates, but also
exception classes if present.</p>
*/
public interface IgniteThrottledLogger extends IgniteLogger {
- /** Throttle timeout in milliseconds (value is 5 min). */
- long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+ /** JVM property to configure a throttle interval. */
+ String THROTTLE_TIMEOUT_MILLIS = "IGNITE_THROTTLE_TIMEOUT_MILLIS";
+
+ /** Default throttle timeout in milliseconds (value is 5 min). */
+ long DEFAULT_THROTTLE_TIMEOUT = TimeUnit.MINUTES.toMillis(5);
Review Comment:
1. My bad.
2. Up to you, but we have 2 variables `DEFAULT_LOG_THROTTLE_INTERVAL_MS` and
`LOG_THROTTLE_INTERVAL_MS` where the first one is `long` and the last one is
`String`, their purposes and actual value are different, that's why I suggested
to name a property name in this way.
But still, we have no now any conventions, so it's just my proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
