ptupitsyn commented on code in PR #5017:
URL: https://github.com/apache/ignite-3/pull/5017#discussion_r1912846171
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/executor/ComputeExecutorImpl.java:
##########
@@ -94,27 +95,31 @@ public <T, R> JobExecutionInternal<R> executeJob(
Marshaller<T, byte[]> inputMarshaller = jobInstance.inputMarshaller();
Marshaller<R, byte[]> resultMarshaller =
jobInstance.resultMarshaller();
- // If input is of this type, this means that the request came from the
thin client and packing the result to the byte array will be
- // needed in any case. In order to minimize conversion, marshal the
result here.
- boolean marshalResult = input instanceof ComputeJobDataHolder;
-
- QueueExecution<R> execution = executorService.submit(
- unmarshalExecMarshal(input, jobClass, jobInstance, context,
inputMarshaller),
+ QueueExecution<ComputeJobDataHolder> execution =
executorService.submit(
+ unmarshalExecMarshal(input, jobClass, jobInstance, context,
inputMarshaller, resultMarshaller),
options.priority(),
options.maxRetries()
);
- return new JobExecutionInternal<>(execution, isInterrupted,
resultMarshaller, marshalResult);
+ return new JobExecutionInternal<>(execution, isInterrupted, null,
false);
Review Comment:
Turns out it is still required for `ClientComputeExecuteMapReduceRequest`.
Separate ticket created:
https://issues.apache.org/jira/browse/IGNITE-24190
It can be done after 3.0 release (does not affect wire protocol), let's not
do it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
