sashapolo commented on code in PR #5039:
URL: https://github.com/apache/ignite-3/pull/5039#discussion_r1916559697
##########
modules/configuration-annotation-processor/src/main/java/org/apache/ignite/internal/configuration/processor/ConfigurationProcessor.java:
##########
@@ -163,14 +163,14 @@ private boolean process0(RoundEnvironment
roundEnvironment) {
return false;
}
- var injectedValueValidator = new InjectedValueValidator(processingEnv);
+ List<Validator> validators = validators();
for (TypeElement clazz : annotatedConfigs) {
var classWrapper = new ClassWrapper(processingEnv, clazz);
- validateConfigurationSchemaClass(classWrapper);
+ validators.forEach(validator -> validator.validate(classWrapper));
Review Comment:
It's not that big of a problem, tbh. There are a constant (small) number of
validators called on a small number of classes, so there should be no
difference in performance. So the priority is to have less code and to make it
as simple as possible. Having a separate `annotation -> validator` mapping
seems like just more code to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
