rpuch commented on code in PR #4902:
URL: https://github.com/apache/ignite-3/pull/4902#discussion_r1919665670
##########
modules/api/src/main/java/org/apache/ignite/tx/TransactionOptions.java:
##########
@@ -39,10 +39,17 @@ public long timeoutMillis() {
/**
* Sets transaction timeout, in milliseconds.
*
- * @param timeoutMillis Transaction timeout, in milliseconds.
+ * @param timeoutMillis Transaction timeout, in milliseconds. Cannot be
negative; 0 means 'use default timeout'.
+ * For RO transactions, the default timeout is data availability time
configured via ignite.gc.lowWatermark.dataAvailabilityTime
+ * configuration setting.
+ * For RW transactions, timeouts are not supported yet. TODO:
IGNITE-15936
* @return {@code this} for chaining.
*/
public TransactionOptions timeoutMillis(long timeoutMillis) {
Review Comment:
Let's decide this out of this PR (which is already pretty big) as this
matter doesn't seem to be a blocker. I filed an issue
https://issues.apache.org/jira/browse/IGNITE-24240
##########
modules/api/src/main/java/org/apache/ignite/tx/TransactionOptions.java:
##########
@@ -39,10 +39,17 @@ public long timeoutMillis() {
/**
* Sets transaction timeout, in milliseconds.
*
- * @param timeoutMillis Transaction timeout, in milliseconds.
+ * @param timeoutMillis Transaction timeout, in milliseconds. Cannot be
negative; 0 means 'use default timeout'.
+ * For RO transactions, the default timeout is data availability time
configured via ignite.gc.lowWatermark.dataAvailabilityTime
+ * configuration setting.
+ * For RW transactions, timeouts are not supported yet. TODO:
IGNITE-15936
* @return {@code this} for chaining.
*/
public TransactionOptions timeoutMillis(long timeoutMillis) {
Review Comment:
Let's resolve this out of this PR (which is already pretty big) as this
matter doesn't seem to be a blocker. I filed an issue
https://issues.apache.org/jira/browse/IGNITE-24240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
