kgusakov commented on PR #5027: URL: https://github.com/apache/ignite-3/pull/5027#issuecomment-2598342820
> > Ticket description was fixed. Still think that the additional dependency from the core module creates more potential issues in future, than fixes now. > > Please describe what potential issues there might be. Every additional dependency makes it difficult to change the project structure in future. On the other hand the only plus is a nullCompletedFuture() vs completedFuture(null) - it is the same number of symbols though and nullCompletedFuture() will never encapsulate any logic I suppose. But on the other hand: core module is a special type of module, looks like we will never want to create any deps in it, which can create a problem cases. Will fix it here, ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
