alievmirza commented on code in PR #5066:
URL: https://github.com/apache/ignite-3/pull/5066#discussion_r1920368142
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java:
##########
@@ -221,11 +228,27 @@ private WatchListener
createDistributionZonesDataNodesListener() {
return nullCompletedFuture();
}
- Set<String> filteredDataNodes = filterDataNodes(
- dataNodes,
- zoneDescriptor,
- distributionZoneManager.nodesAttributes()
- );
+ Map<UUID, NodeWithAttributes> nodesAttributes =
distributionZoneManager.nodesAttributes();
+
+ Set<String> filteredDataNodes = filterDataNodes(dataNodes,
zoneDescriptor, nodesAttributes);
+
+ if (LOG.isInfoEnabled()) {
+ List<NodeWithAttributes> filteredOutNodes = dataNodes.stream()
+ .filter(node ->
!filteredDataNodes.contains(node.nodeName()))
+ .map(node -> nodesAttributes.get(node.nodeId()))
+ .collect(toList());
+
+ if (!filteredOutNodes.isEmpty()) {
+ LOG.info(
+ "Some data nodes were filtered out because they
don't match zone's attributes: "
Review Comment:
What do you think about adding to the log info about the whole data nodes
set? Will it be more informative or redundant? Like "Some data nodes were
filtered out from data nodes because they don't match zone's attributes:
dataNodes={}....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
