korlov42 commented on code in PR #5069:
URL: https://github.com/apache/ignite-3/pull/5069#discussion_r1924929528
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/InternalTransaction.java:
##########
@@ -91,6 +91,13 @@ public interface InternalTransaction extends Transaction {
*/
HybridTimestamp startTimestamp();
+ /**
+ * Returns an observable timestamp provided by the observable timestamp
tracker.
+ *
+ * @return observable timestamp, or {@code null} if the observable time
has not yet been initialized/updated.
+ */
+ @Nullable HybridTimestamp observableTimestamp();
Review Comment:
I would suggest to save tracker in `JdbcConnectionContext` along with
created transaction instead of adding a new method to `InternalTransaction`
##########
modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java:
##########
@@ -161,6 +162,9 @@ public class IgniteJdbcDriver implements Driver {
/** Minor version. */
private static final int MINOR_VER = ProtocolVersion.LATEST_VER.minor();
+ /** Tracker of the latest time observed by client. */
+ private final HybridTimestampTracker observableTimeTracker =
HybridTimestampTracker.atomicTracker(null);
Review Comment:
it would be nice to throw a few lines describing rationale behind having a
single tracker per driver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
