alievmirza commented on code in PR #5064:
URL: https://github.com/apache/ignite-3/pull/5064#discussion_r1926826622
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/distributed/disaster/AbstractHighAvailablePartitionsRecoveryTest.java:
##########
@@ -132,10 +142,71 @@ private void
waitAndAssertStableAssignmentsOfPartitionEqualTo(
.collect(Collectors.toUnmodifiableSet()));
}
+ final void
waitAndAssertEmptyRebalanceKeysAndStableAssignmentsOfPartitionEqualTo(
Review Comment:
The name of the method is a bit ambiguous, it could be understood that
stable is also must be null. Please improve naming and a javadoc explaining
what do we assert in this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]