korlov42 commented on code in PR #5111:
URL: https://github.com/apache/ignite-3/pull/5111#discussion_r1928568140


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java:
##########
@@ -357,6 +358,26 @@ public interface ClusterBuilder {
          */
         ClusterBuilder nodes(String firstNodeName, String... otherNodeNames);
 
+        /**
+         * A decorator to wrap {@link CatalogManager} instance which will be 
used int test cluster.

Review Comment:
   fixed, thanks



##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSqlMultiStatementTxTest.java:
##########
@@ -304,6 +305,9 @@ void dmlFailsOnReadOnlyTransaction() {
         assertThrowsSqlException(RUNTIME_ERR, "DML cannot be started by using 
read only transactions.",
                 () -> await(insCur.nextResult()));
 
+        assertThrowsSqlException(EXECUTION_CANCELLED_ERR, "The query was 
cancelled while executing.",
+                () -> await(insCur.requestNextAsync(1)));

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to