korlov42 commented on code in PR #5112:
URL: https://github.com/apache/ignite-3/pull/5112#discussion_r1930448627
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java:
##########
@@ -42,7 +34,8 @@
* <li>Events are fired in the metastore thread.</li>
* </ul>
*
- * <p>TBD: events
+ * @see CatalogEvent Full list of events, which is fired by the catalog
service.
+ * @see CatalogManager The manager, which provides catalog manipulation
methods and is responsible for managing distributed operations.
*/
public interface CatalogService extends EventProducer<CatalogEvent,
CatalogEventParameters> {
Review Comment:
`@Nullable` is not about expectations, it's about contract. Currently, it
may return null under certain conditions, and I think it would be beneficiary
to document those.
I don't mind to remove this annotation, but we need to make sure this method
never returns null in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
