rpuch commented on code in PR #5093:
URL: https://github.com/apache/ignite-3/pull/5093#discussion_r1935661590
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/configuration/TransactionConfigurationSchema.java:
##########
@@ -28,23 +28,20 @@
*/
@Config
public class TransactionConfigurationSchema {
- /** Default checking transaction interval. */
- public static final long DEFAULT_ABANDONED_CHECK_TS = 5_000;
-
/** How often abandoned transactions are searched for (milliseconds). */
@Range(min = 0)
@Value(hasDefault = true)
- public final long abandonedCheckTs = DEFAULT_ABANDONED_CHECK_TS;
+ public final long abandonedCheckTs = 5_000;
- /** Default transaction timeout (milliseconds). */
+ /** Default timeout for read-only transactions. */
@Range(min = 1)
@Value(hasDefault = true)
- public final long timeout = 10_000;
Review Comment:
Because 3.0.0 already contains `transaction.timeout` config property. If we
just remove it, then our next release will potentially break them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
