ivanzlenko commented on code in PR #5155:
URL: https://github.com/apache/ignite-3/pull/5155#discussion_r1937448861
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/rocksdb/TxStateRocksDbSharedStorage.java:
##########
@@ -135,12 +163,19 @@ CompletableFuture<Void> awaitFlush(boolean schedule) {
return flusher.awaitFlush(schedule);
}
+ @Override
+ public CompletableFuture<Void> startAsync(ComponentContext
componentContext) {
+ start();
Review Comment:
Shouldn't we remove failed future here?
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/rocksdb/TxStateRocksDbSharedStorage.java:
##########
@@ -135,12 +163,19 @@ CompletableFuture<Void> awaitFlush(boolean schedule) {
return flusher.awaitFlush(schedule);
}
+ @Override
+ public CompletableFuture<Void> startAsync(ComponentContext
componentContext) {
+ start();
Review Comment:
Shouldn't we remove failed future here in case of exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
