korlov42 commented on code in PR #5143:
URL: https://github.com/apache/ignite-3/pull/5143#discussion_r1940632894
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -496,23 +514,6 @@ private AsyncDataCursor<InternalSqlRow> executeKill(
return new IteratorToDataCursorAdapter<>(ret, Runnable::run);
}
- private static RuntimeException convertDdlException(Throwable e) {
- e = ExceptionUtils.unwrapCause(e);
-
- if (e instanceof ConfigurationChangeException) {
- assert e.getCause() != null;
- // Cut off upper configuration error`s as uninformative.
- e = e.getCause();
- }
-
- if (e instanceof IgniteInternalCheckedException) {
- return new IgniteInternalException(INTERNAL_ERR, "Failed to
execute DDL statement [stmt=" /* + qry.sql() */
- + ", err=" + e.getMessage() + ']', e);
- }
-
- return (e instanceof RuntimeException) ? (RuntimeException) e : new
IgniteInternalException(INTERNAL_ERR, e);
Review Comment:
I propose to do it separately in
https://issues.apache.org/jira/browse/IGNITE-24387. It would be nice to revise
test coverage for exception remapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
