tkalkirill commented on code in PR #5171:
URL: https://github.com/apache/ignite-3/pull/5171#discussion_r1941233918
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/logit/option/StoreOptions.java:
##########
@@ -17,23 +17,27 @@
package org.apache.ignite.raft.jraft.storage.logit.option;
+import org.apache.ignite.internal.lang.IgniteSystemProperties;
+import org.apache.ignite.internal.util.Constants;
import org.apache.ignite.raft.jraft.storage.logit.storage.file.FileHeader;
import
org.apache.ignite.raft.jraft.storage.logit.storage.file.index.IndexFile.IndexEntry;
/**
* Storage options
*/
public class StoreOptions {
+ public static final String LOGIT_STORAGE_SEGMENT_FILE_SIZE_PROPERTY =
"LOGIT_STORAGE_SEGMENT_FILE_SIZE";
Review Comment:
What do you think, maybe we should do something similar to Ignite 2 and add
the prefix "IGNITE_" to such properties?
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/logit/option/StoreOptions.java:
##########
@@ -17,23 +17,27 @@
package org.apache.ignite.raft.jraft.storage.logit.option;
+import org.apache.ignite.internal.lang.IgniteSystemProperties;
+import org.apache.ignite.internal.util.Constants;
import org.apache.ignite.raft.jraft.storage.logit.storage.file.FileHeader;
import
org.apache.ignite.raft.jraft.storage.logit.storage.file.index.IndexFile.IndexEntry;
/**
* Storage options
*/
public class StoreOptions {
+ public static final String LOGIT_STORAGE_SEGMENT_FILE_SIZE_PROPERTY =
"LOGIT_STORAGE_SEGMENT_FILE_SIZE";
Review Comment:
Please add documentation to the properties and tell us what they are for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
