ygerzhedovich commented on code in PR #5167:
URL: https://github.com/apache/ignite-3/pull/5167#discussion_r1943013731
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -197,6 +205,8 @@ public DdlSqlToCommandConverter() {
DATA_NODES_AUTO_ADJUST_SCALE_DOWN,
new DdlOptionInfo<>(Integer.class, this::checkPositiveNumber,
AlterZoneCommandBuilder::dataNodesAutoAdjustScaleDown)
));
+
+ alterReplicasOptionInfo = new DdlOptionInfo<>(Integer.class,
this::checkPositiveNumber, AlterZoneCommandBuilder::replicas);
Review Comment:
Why do you need to have two instances of DdlOptionsInfor for CREATE and
ALTER? Are they supposed to be different over time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
