sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943468073
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -2128,13 +2149,21 @@ public CompletableFuture<Long> estimatedSize() {
var invokeFutures = new CompletableFuture<?>[partitions];
for (int partId = 0; partId < partitions; partId++) {
- var replicaGroupId = new TablePartitionId(tableId, partId);
+ ReplicationGroupIdMessage partitionIdMessage;
Review Comment:
This code refers/uses the `enabledColocationFeature` variable, so it will
not compile when the system property is removed. So, it looks straightforward
that this code should be cleaned up in the future, I see no issues here.
On the other hand, it is easy to add one more comment about it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
