rpuch commented on code in PR #5166:
URL: https://github.com/apache/ignite-3/pull/5166#discussion_r1942997864
##########
modules/configuration-api/src/main/java/org/apache/ignite/configuration/validation/ConfigurationValidationException.java:
##########
@@ -41,7 +41,7 @@ public ConfigurationValidationException(String message) {
*
* @param issues List of issues occurred during validation.
*/
- public ConfigurationValidationException(List<ValidationIssue> issues) {
+ public ConfigurationValidationException(Collection<ValidationIssue>
issues) {
super(createMessageFromIssues(issues));
this.issues = issues;
Review Comment:
Let's make a defensive copy, by the way
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java:
##########
@@ -234,26 +259,71 @@ private static boolean isInstance(Object configNode) {
return CLASS.isInstance(configNode);
}
- private static String path(Object firstChild) {
+ /** Return full path to the given node. Elements of array don't have a
NodePath child, so index is used instead. */
Review Comment:
```suggestion
/** Returns full path to the given node. Elements of array don't
have a NodePath child, so index is used instead. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
