rpuch commented on code in PR #5159:
URL: https://github.com/apache/ignite-3/pull/5159#discussion_r1944345768
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -485,6 +494,12 @@ private CompletableFuture<Void>
createZonePartitionReplicationNode(
stablePeersAndLearners,
raftGroupListener,
raftGroupEventsListener,
+ // TODO: IGNITE-24371 - pass real isVolatile
flag
+ false,
+ () ->
zoneResourcesManager.getOrCreatePartitionStorage(
+ zoneDescriptorAt(zoneId,
stableAssignments.timestamp()),
Review Comment:
I don't take zone descriptor from the catalog anymore
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -485,6 +494,12 @@ private CompletableFuture<Void>
createZonePartitionReplicationNode(
stablePeersAndLearners,
raftGroupListener,
raftGroupEventsListener,
+ // TODO: IGNITE-24371 - pass real isVolatile
flag
+ false,
+ () ->
zoneResourcesManager.getOrCreatePartitionStorage(
+ zoneDescriptorAt(zoneId,
stableAssignments.timestamp()),
Review Comment:
I don't take zone descriptor from the catalog anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
