zstan commented on code in PR #5145:
URL: https://github.com/apache/ignite-3/pull/5145#discussion_r1946020825
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java:
##########
@@ -715,16 +717,26 @@ private static TypeSpec convertToTypeSpec(RelDataType
type) {
* <br>
* 2) If one or more of the rightmost M-L characters of V are not
space(s), then an
* exception condition is raised: data exception — string data, right
truncation.
+ * <br><br>
+ * If the declared type of T is binary string and the length in octets M
of V is greater than
+ * the maximum length in octets L of T, then:
+ * <br>
+ * 1) If the rightmost M0L octets of V are all equal to X’00’, then the
value of T is set to
Review Comment:
done, miss copy-paste problem from pdf
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java:
##########
@@ -715,16 +717,26 @@ private static TypeSpec convertToTypeSpec(RelDataType
type) {
* <br>
* 2) If one or more of the rightmost M-L characters of V are not
space(s), then an
* exception condition is raised: data exception — string data, right
truncation.
+ * <br><br>
+ * If the declared type of T is binary string and the length in octets M
of V is greater than
+ * the maximum length in octets L of T, then:
+ * <br>
+ * 1) If the rightmost M0L octets of V are all equal to X’00’, then the
value of T is set to
+ * the first L octets of V and the length in octets of T is set to L.
+ * <br>
+ * 2) If one or more of the rightmost M0L octets of V are not equal to
X’00’, then an
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
