rpuch commented on code in PR #5201:
URL: https://github.com/apache/ignite-3/pull/5201#discussion_r1948844566
##########
modules/placement-driver/src/test/java/org/apache/ignite/internal/placementdriver/leases/LeaseBatchSerializerTest.java:
##########
@@ -94,10 +100,33 @@ void batchWithTablePartitionsOnly() {
false,
false,
null,
- new TablePartitionId(2, 1)
+ groupIdFactory.apply(2, 1)
)
);
+ }
+
+ private static Stream<Arguments> leasesSource() {
+ return Stream.of(
+ arguments(createLeases(baseTs(), TablePartitionId::new)),
+ arguments(createLeases(baseTs(), ZonePartitionId::new)),
+ arguments(
+ Stream.concat(
+ createLeases(baseTs(),
TablePartitionId::new).stream(),
+ createLeases(baseTs(),
ZonePartitionId::new).stream()
+ ).collect(toList())
+ ),
+ arguments(
+ Stream.concat(
+ createLeases(baseTs(),
ZonePartitionId::new).stream(),
+ createLeases(baseTs(),
TablePartitionId::new).stream()
+ ).collect(toList())
+ )
+ );
+ }
Review Comment:
I would suggest to add an analog of v1CanBeDeserialized() for a batch
containing zone partition leases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
