sashapolo commented on code in PR #5212:
URL: https://github.com/apache/ignite-3/pull/5212#discussion_r1954322940
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/outgoing/OutgoingSnapshot.java:
##########
@@ -486,17 +509,16 @@ public boolean addRowIdToSkip(RowId rowId) {
* @param rowId RowId.
* @return {@code true} if the given RowId is already passed by the
snapshot in normal rows sending order.
*/
- public boolean alreadyPassed(RowId rowId) {
+ public boolean alreadyPassed(int tableId, RowId rowId) {
assert mvOperationsLock.isLocked() : "MV operations lock must be
acquired!";
- if (!startedToReadMvPartition) {
- return false;
- }
if (finishedMvData()) {
return true;
}
- return rowId.compareTo(lastRowId) <= 0;
+ return partitionDeliveryState != null
+ && tableId <= partitionDeliveryState.currentTableId()
+ && rowId.compareTo(partitionDeliveryState.currentRowId()) <= 0;
Review Comment:
Nice catch, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
