timoninmaxim commented on code in PR #11866:
URL: https://github.com/apache/ignite/pull/11866#discussion_r1960110710
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -1792,23 +1792,29 @@ public
IgniteInternalFuture<SnapshotPartitionsVerifyTaskResult> checkSnapshot(
kctx0.task().execute(
cls,
new SnapshotPartitionsVerifyTaskArg(grps, metas,
snpPath, incIdx, check),
- options(new ArrayList<>(metas.keySet()))
- ).listen(f1 -> {
- if (f1.error() == null)
- res.onDone(f1.result());
- else if (f1.error() instanceof
IgniteSnapshotVerifyException)
- res.onDone(new
SnapshotPartitionsVerifyTaskResult(metas,
- new
IdleVerifyResult(((IgniteSnapshotVerifyException)f1.error()).exceptions())));
- else
- res.onDone(f1.error());
- });
+ options(new ArrayList<>(metas.keySet()))
Review Comment:
Let's not change indention.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandler.java:
##########
@@ -437,23 +434,23 @@ private PartitionHashRecord
calculateDumpedPartitionHash(Dump dump, String grpNa
/** {@inheritDoc} */
@Override public void complete(String name,
Collection<SnapshotHandlerResult<Map<PartitionKey,
PartitionHashRecord>>> results) throws IgniteCheckedException {
- Map<PartitionKey, List<PartitionHashRecord>> clusterHashes = new
HashMap<>();
- Map<ClusterNode, Exception> errs = new HashMap<>();
Review Comment:
Looks like we can use `bldr.exceptions()` everywhere for collection errors.
Do we need separate `addException` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
