sanpwc commented on code in PR #5241:
URL: https://github.com/apache/ignite-3/pull/5241#discussion_r1962120556
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -417,7 +424,11 @@ private IgniteBiTuple<Serializable, Boolean>
handleWriteIntentSwitchCommand(
UUID txId = cmd.txId();
- txFinisher.markFinished(txId, cmd.commit(), cmd.commitTimestamp(),
null);
+ if (!enabledColocationFeature) {
Review Comment:
That's a bit weird. We've agreed to introduce CommandHandlers both for
better incapsulation and in order to reduce the rick of missing updates.
In case of WISC processing `PartitionListener#processCommand` still uses
common method
```
} else if (command instanceof WriteIntentSwitchCommand) {
result =
handleWriteIntentSwitchCommand((WriteIntentSwitchCommand) command,
commandIndex, commandTerm);
```
thus second goal is not achieved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
