vadimkolodingg commented on code in PR #5244:
URL: https://github.com/apache/ignite-3/pull/5244#discussion_r1965626926
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java:
##########
@@ -200,7 +201,14 @@ public static CompletableFuture<Void>
updatePendingAssignmentsKeys(
boolean isNewAssignments =
!tableCfgPartAssignments.equals(partAssignments);
- byte[] partAssignmentsBytes = Assignments.toBytes(partAssignments,
assignmentsTimestamp);
+ Assignments partAssignmentsPlanned = Assignments.of(partAssignments,
assignmentsTimestamp);
+ AssignmentsQueue partAssignmentsPending = new
AssignmentsQueue(partAssignmentsPlanned);
+
+ assert
partAssignmentsPlanned.equals(partAssignmentsPending.peekLast());
+
+ byte[] partAssignmentsPlannedBytes = partAssignmentsPlanned.toBytes();
+ byte[] partAssignmentsBytes = partAssignmentsPending.toBytes();
Review Comment:
prefixes renamed - e.g. `PENDING_ASSIGNMENTS_QUEUE_PREFIX`, `rebalance.md`
and pseudocode comments updated, logs updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
