sanpwc commented on code in PR #5246:
URL: https://github.com/apache/ignite-3/pull/5246#discussion_r1967143649
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1823,15 +1816,8 @@ private CompletableFuture<Void> completeScan(
CompletableFuture<Void> closeFut = nullCompletedFuture();
if (explicitCloseCursor) {
- // I don't use the new colocation aware method for the ID because
we pass TablePartitionId object there. I can't change the
- // method's signature right now because the id object is created
outside of the method and is used in several places more than
- // just the method's call.
- ReplicationGroupId colocationAwareReplicationGroupId =
enabledColocation()
- ? new ZonePartitionId(zoneId,
partitionIndexFromReplicationGroupId(replicaGrpId))
Review Comment:
partitionIndexFromReplicationGroupId no longer needed, please remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
