FewJuho commented on code in PR #11855:
URL: https://github.com/apache/ignite/pull/11855#discussion_r1971846291
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java:
##########
@@ -703,7 +704,8 @@ synchronized void initChannelHolders() {
curAddrs.putIfAbsent(addr, hld);
}
- reinitHolders.add(hld);
+ if (!reinitHolders.contains(hld))
Review Comment:
Since I rewrote validAddrsSet to be of type Set<List<InetSocketAddress>>
instead of Set<InetSocketAddress>, this allowed us to restore as normal
hld.setConfiguration and hld = new ClientChannelHolder. However, now there can
be duplicate holders across different addresses, and we need to filter them to
remove duplicates.
We can first make reinitHolders a Set, and after adding the holders, convert
it back to a List.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
