JAkutenshi commented on code in PR #5300:
URL: https://github.com/apache/ignite-3/pull/5300#discussion_r1978816637
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageUtils.java:
##########
@@ -137,6 +138,7 @@ public static void
throwExceptionDependingOnStorageStateOnRebalance(StorageState
public static void throwExceptionDependingOnStorageState(StorageState
state, String storageInfo) {
switch (state) {
case CLOSED:
+ assert !IgniteSystemProperties.enabledColocation() :
createStorageClosedErrorMessage(storageInfo);
Review Comment:
>Do you have a precedent for this?
E.g. I ran `testTableEstimatedSize` as `@RepeatedTest(20)` and 15 out of 20
contain `Storage is already closed`.
>Why does accessing a closed storage not result in test failures?
In most of runs previously there was the exception on a node stop, but it
didn't affect on TC runs, because it happend on `@AfterEach` without fail
behavior. Our TC reacts only for `AssertionError` and `NullPointerException`
thus we couldn't detect the closed exception before.
>why do you only check the CLOSED status and no other statuses?
Because this state disturbs me most.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
