slukyano commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984161233
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/cluster/ClusterInitCallInput.java:
##########
@@ -35,8 +35,8 @@ public class ClusterInitCallInput implements CallInput {
private ClusterInitCallInput(
String clusterUrl,
- List<String> metaStorageNodes,
- List<String> cmgNodes,
+ @Nullable List<String> metaStorageNodes,
Review Comment:
We could but I think null has clearer semantics for CLI parameters - it
means "the user has not specified the parameter" rather than "the user has
found a way to specify an empty list".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
