Phillippko commented on code in PR #5358:
URL: https://github.com/apache/ignite-3/pull/5358#discussion_r1984434716
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/time/ClusterTimeImpl.java:
##########
@@ -209,30 +233,42 @@ synchronized void schedule() {
}
currentTask = executorService.schedule(() -> {
- if (!busyLock.enterBusy()) {
- return;
- }
-
try {
- syncTimeAction.syncTime(clock.now())
- .whenComplete((v, e) -> {
- if (e != null) {
- Throwable cause = unwrapCause(e);
-
- if (!(cause instanceof
CancellationException) && !(cause instanceof NodeStoppingException)) {
- LOG.error("Unable to perform idle time
sync", e);
- }
- }
- });
+ tryToSyncTimeAndReschedule();
+ } catch (Throwable t) {
+ failureManager.process(new
FailureContext(FailureType.CRITICAL_ERROR, t));
Review Comment:
We need to process only exceptions in the "sync" part, not exceptional
completion of future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
