12rcu commented on code in PR #5158:
URL: https://github.com/apache/ignite-3/pull/5158#discussion_r1984650114
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -2710,28 +2717,33 @@ public void
testAppendEntriesWhenFollowerIsInErrorState() throws Exception {
}
@Test
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-21792";)
+ @Timeout(value = 25, unit = TimeUnit.SECONDS)
public void testFollowerStartStopFollowing() throws Exception {
// start five nodes
List<TestPeer> peers = TestUtils.generatePeers(testInfo, 5);
- cluster = new TestCluster("unitest", dataPath, peers,
ELECTION_TIMEOUT_MILLIS, testInfo);
+ cluster = new TestCluster("unittest", dataPath, peers,
ELECTION_TIMEOUT_MILLIS, testInfo);
for (TestPeer peer : peers)
assertTrue(cluster.start(peer));
Node firstLeader = cluster.waitAndGetLeader();
assertNotNull(firstLeader);
cluster.ensureLeader(firstLeader);
+ //we don't want any timeouts after the first leader election for this
test
+ for (Node nodes : cluster.getNodes()) {
+ nodes.resetElectionTimeoutMs(100_000);
Review Comment:
Hi @alievmirza thanks for your review!. I don't quite understand your point.
From my point of view, what happened was that the flakiness didn't occur when
the leader was stopped, but only when running into the actual election timeout.
The purpose of this test is to take advantage of the fact that when a leader is
stopped, a new round of election is triggered.
Maybe the comment is confusing because I didn't want to call a "leader stop"
an election timeout (even though under the hood this may use
TimeoutNowRequest). Or are we talking about a completely different timeout
mechanism? I didn't came across this TimeoutNowRequest while searching for the
flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
