PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1983183619
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java:
##########
@@ -113,22 +113,31 @@ public TablePartitionId commitPartition() {
@Override
public CompletableFuture<Void> commitAsync() {
return TransactionsExceptionMapperUtil.convertToPublicFuture(
- finish(true, readTimestamp, false),
+ finish(true, readTimestamp, false, false),
TX_COMMIT_ERR
);
}
@Override
public CompletableFuture<Void> rollbackAsync() {
return TransactionsExceptionMapperUtil.convertToPublicFuture(
- finish(false, readTimestamp, false),
+ finish(false, readTimestamp, false, false),
TX_ROLLBACK_ERR
);
}
@Override
- public CompletableFuture<Void> finish(boolean commit, HybridTimestamp
executionTimestamp, boolean full) {
+ public CompletableFuture<Void> rollbackTimeoutExceededAsync() {
+ return TransactionsExceptionMapperUtil.convertToPublicFuture(
+ finish(false, readTimestamp, false, true),
+ TX_ROLLBACK_ERR
+ ).thenAccept(unused -> this.timeoutExceeded = true);
Review Comment:
Rewrote that part. Moved the flag change into `finish` method for Read Tx
and into `finishInternal` for Read Write Tx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
