ibessonov commented on code in PR #5389:
URL: https://github.com/apache/ignite-3/pull/5389#discussion_r1990817307
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java:
##########
@@ -304,7 +304,7 @@ private static CompletableFuture<Integer> partitionUpdate(
long revision,
MetaStorageManager metaStorageMgr,
Set<Assignment> currentAssignments,
- LocalPartitionStateMessageByNode localPartitionStateMessageByNode,
+ @Nullable LocalPartitionStateMessageByNode
localPartitionStateMessageByNode,
Review Comment:
Can we simply pass an empty map instead of null, instead of duplicating the
calculating logic in `nextAssignment`? I don't like copy-pasted algorithms,
they make code harder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
