ibessonov commented on code in PR #5483:
URL: https://github.com/apache/ignite-3/pull/5483#discussion_r2009889230


##########
modules/raft/src/test/java/org/apache/ignite/raft/jraft/rpc/impl/cli/SnapshotRequestProcessorTest.java:
##########
@@ -16,16 +16,17 @@
  */
 package org.apache.ignite.raft.jraft.rpc.impl.cli;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;

Review Comment:
   Why did you reorder these imports?



##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/snapshot/SnapshotExecutorImpl.java:
##########
@@ -309,12 +316,15 @@ public void doSnapshot(final Closure done) {
                 doUnlock = false;
                 this.lock.unlock();
                 this.logManager.clearBufferedLogs();
-                
Utils.runClosureInThread(this.node.getOptions().getCommonExecutor(), done);
+                Status status = forced

Review Comment:
   Please add a clarifying comment, thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to