alievmirza commented on code in PR #5468:
URL: https://github.com/apache/ignite-3/pull/5468#discussion_r2014021474
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogSchemaDescriptorSerializers.java:
##########
@@ -57,13 +61,16 @@ public CatalogSchemaDescriptor
readFrom(CatalogObjectDataInput input) throws IOE
int id = input.readVarIntAsInt();
String name = input.readUTF();
- long updateToken = input.readVarInt();
+
+ // Read the update token.
+ input.readVarInt();
CatalogTableDescriptor[] tables =
readArray(tableDescriptorSerializer, input, CatalogTableDescriptor.class);
CatalogIndexDescriptor[] indexes = readArray(indexSerializeHelper,
input, CatalogIndexDescriptor.class);
CatalogSystemViewDescriptor[] systemViews =
readArray(viewDescriptorSerializer, input, CatalogSystemViewDescriptor.class);
- return new CatalogSchemaDescriptor(id, name, tables, indexes,
systemViews, updateToken);
+ // Here we use the initial timestamp because it's old storage.
This value will be processed by data nodes manager.
Review Comment:
This comment is correct only for ZoneDescriptor serialiser, because only
ZoneDescriptor actually uses updateTimestamp and uses it in data nodes manager.
For all other serialisers, like for TableDescriptor and etc, phrase like "This
value will be processed by data nodes manager." is incorrect. Please, fix
comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
