xtern commented on code in PR #5490:
URL: https://github.com/apache/ignite-3/pull/5490#discussion_r2015722777
##########
modules/sql-engine/src/main/codegen/includes/parserImpls.ftl:
##########
@@ -675,19 +675,32 @@ SqlTypeNameSpec IgniteDateTimeTypeName() :
|
<TIME> { s = span(); }
precision = PrecisionOpt()
+ (<WITHOUT> <TIME> <ZONE>)?
{
typeName = SqlTypeName.TIME;
return new SqlBasicTypeNameSpec(typeName, precision, s.end(this));
}
|
<TIMESTAMP> { s = span(); }
precision = PrecisionOpt()
- typeName = TimeZoneOpt(false)
+ typeName = TimestampZoneOpt()
{
return new SqlBasicTypeNameSpec(typeName, precision, s.end(this));
}
}
+SqlTypeName TimestampZoneOpt() :
+{
+}
+{
+ LOOKAHEAD(3)
Review Comment:
Thanks, removed, looks redundant.
Was copy pasted from calcite :roll_eyes:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
