rpuch commented on code in PR #5509:
URL: https://github.com/apache/ignite-3/pull/5509#discussion_r2016562483
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2883,6 +2879,10 @@ private CompletableFuture<Void>
stopTablePartition(TablePartitionId tablePartiti
return stopReplicaFuture
.thenCompose(v -> {
+ if (table != null) {
Review Comment:
Removed the null check (but added a couple of assertions just in case).
As for unconditional closure of trackers: it is idempotent, so it seems that
it's better to call it than not. Also, replica stop might return if it failed
to stop Raft node due to Ignite node being stopped, and in this case we still
need to close the trackers, as it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
