isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022790027
##########
modules/platforms/cpp/ignite/client/sql/sql.h:
##########
@@ -44,49 +45,57 @@ class sql {
sql() = delete;
/**
- * Executes single SQL statement asynchronously and returns rows.
+ * Executes a single SQL statement asynchronously and returns rows.
*
* @param tx Optional transaction. If nullptr implicit transaction for
this single operation is used.
+ * @param token Cancellation token. Can be @c nullptr.
* @param statement Statement to execute.
* @param args Arguments for the statement (can be empty).
* @param callback A callback called on operation completion with SQL
result set.
*/
- IGNITE_API void execute_async(transaction *tx, const sql_statement
&statement, std::vector<primitive> args,
- ignite_callback<result_set> callback);
+ IGNITE_API void execute_async(transaction *tx, cancellation_token *token,
const sql_statement &statement,
+ std::vector<primitive> args, ignite_callback<result_set> callback);
Review Comment:
This issue should probably be addressed in another way, because right now we
have like 5 arguments, 4 of which can be optional independently of each other.
That's a hell of overloads. I prefer to live it like this until we come up with
a common solution for cases like this - we can always add overloads in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
