Copilot commented on code in PR #5567:
URL: https://github.com/apache/ignite-3/pull/5567#discussion_r2026917917
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -648,9 +649,10 @@ private CompletableFuture<Void> destroyCmgWithEvents() {
return inBusyLockAsync(
() ->
fireEvent(ClusterManagerGroupEvent.BEFORE_DESTROY_RAFT_GROUP,
EmptyEventParameters.INSTANCE)
.thenRunAsync(this::destroyCmg, this.scheduledExecutor)
- .exceptionally(err -> {
- failureManager.process(new
FailureContext(CRITICAL_ERROR, err));
- throw (err instanceof RuntimeException) ?
(RuntimeException) err : new CompletionException(err);
+ .whenComplete((v, e) -> {
Review Comment:
The new error handling in destroyCmgWithEvents processes errors without
rethrowing them, which alters the propagation behavior compared to the original
implementation; consider rethrowing the exception or adjusting downstream
handling accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
