valepakh commented on code in PR #5549:
URL: https://github.com/apache/ignite-3/pull/5549#discussion_r2031314939
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/TxBalanceRetryOperationBenchmark.java:
##########
@@ -74,21 +74,14 @@ public class TxBalanceRetryOperationBenchmark extends
AbstractMultiNodeBenchmark
@Param({"waitTimeout", "replicaOperationRetry"})
private String txRetryMode;
+ @Param({"0", "10"})
+ private int replicaOperationRetryInterval;
+
@Override
protected String clusterConfiguration() {
- if (txRetryMode.equals("waitTimeout")) {
- return "ignite {"
- + "transaction: { deadlockPreventionPolicy: { waitTimeout:
30, txIdComparator: NATURAL } },"
- + "replication: { replicaOperationRetryInterval: 0 }"
- + "}";
- } else {
- assert txRetryMode.equals("replicaOperationRetry");
-
- return "ignite {"
- + "transaction: { deadlockPreventionPolicy: { waitTimeout:
0, txIdComparator: NATURAL } },"
- + "replication: { replicaOperationRetryInterval: 10 }"
- + "}";
- }
+ return "ignite {"
+ + "replication: { replicaOperationRetryInterval: " +
replicaOperationRetryInterval + " }"
Review Comment:
I just noticed that this test somehow not fails after the renaming of this
property to `replicaOperationRetryIntervalMillis`
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/TxBalanceRetryOperationBenchmark.java:
##########
@@ -74,21 +74,14 @@ public class TxBalanceRetryOperationBenchmark extends
AbstractMultiNodeBenchmark
@Param({"waitTimeout", "replicaOperationRetry"})
private String txRetryMode;
+ @Param({"0", "10"})
+ private int replicaOperationRetryInterval;
+
@Override
protected String clusterConfiguration() {
- if (txRetryMode.equals("waitTimeout")) {
- return "ignite {"
- + "transaction: { deadlockPreventionPolicy: { waitTimeout:
30, txIdComparator: NATURAL } },"
- + "replication: { replicaOperationRetryInterval: 0 }"
- + "}";
- } else {
- assert txRetryMode.equals("replicaOperationRetry");
-
- return "ignite {"
- + "transaction: { deadlockPreventionPolicy: { waitTimeout:
0, txIdComparator: NATURAL } },"
- + "replication: { replicaOperationRetryInterval: 10 }"
- + "}";
- }
+ return "ignite {"
+ + "replication: { replicaOperationRetryInterval: " +
replicaOperationRetryInterval + " }"
Review Comment:
I just noticed that this test somehow doesn't fail after the renaming of
this property to `replicaOperationRetryIntervalMillis`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
