xtern commented on code in PR #5515:
URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2033196860
##########
modules/platforms/dotnet/Apache.Ignite.Tests/Proto/ColocationHashTests.cs:
##########
@@ -96,10 +96,11 @@ public class ColocationHashTests : IgniteTestsBase
LocalTime.Noon,
LocalDateTime.FromDateTime(DateTime.UtcNow).TimeOfDay,
default(LocalTime),
- new LocalDateTime(year: 1, month: 1, day: 1, hour: 1, minute: 1,
second: 1, millisecond: 1),
+
+ // Minimum allowed DATETIME value.
+ new LocalDateTime(year: 1, month: 1, day: 1, hour: 18, minute: 0,
second: 0, millisecond: 0),
Review Comment:
Done
##########
modules/marshaller-common/src/testFixtures/java/org/apache/ignite/internal/marshaller/testobjects/TestObjectWithAllTypes.java:
##########
@@ -63,8 +62,7 @@ public static TestObjectWithAllTypes randomObject(Random rnd)
{
obj.dateCol = LocalDate.ofYearDay(1990 + rnd.nextInt(50), 1 +
rnd.nextInt(360));
obj.timeCol = LocalTime.of(rnd.nextInt(24), rnd.nextInt(60));
obj.dateTimeCol = LocalDateTime.of(obj.dateCol, obj.timeCol);
- obj.timestampCol =
Instant.ofEpochMilli(rnd.nextLong()).truncatedTo(ChronoUnit.SECONDS)
- .plusNanos(normalizeNanos(rnd.nextInt(1_000_000_000), 6));
+ obj.timestampCol = (Instant) SchemaTestUtils.generateRandomValue(rnd,
NativeTypes.timestamp(6));
Review Comment:
Maybe I didn't quite understand your suggestion, but I rewrote the
generation of all field values using `SchemaTestUtils.generateRandomValue`
> why do we need both:
> obj.primitiveBooleanCol = rnd.nextBoolean();
> and
> obj.booleanCol = rnd.nextBoolean();
I suppose this question is out of scope of this PR)
But I think that in some tests we need to check not only primitives but
boxed values also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
