rpuch commented on code in PR #5612:
URL: https://github.com/apache/ignite-3/pull/5612#discussion_r2039718924
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -598,7 +601,8 @@ private CompletableFuture<?>
createZonePartitionReplicationNode(
Assignments stableAssignments,
long revision,
int partitionCount,
- boolean isVolatileZone
+ boolean isVolatileZone,
+ boolean holdingZoneWriteLock
Review Comment:
If we do it, then pending assignments change events handling (inside the
same zone) will be sequential. Imagine that partitions 1, 2, 3 of the same zone
are now added to pending assignments of node A. If we just take write lock for
any of them, others will need to wait for it. But current approach allows to
keep this parallelism
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
