sashapolo commented on code in PR #5644:
URL: https://github.com/apache/ignite-3/pull/5644#discussion_r2046234039
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -505,15 +505,17 @@ private CompletableFuture<Boolean>
onCreateZone(CreateZoneEventParameters create
return calculateZoneAssignmentsAndCreateReplicationNodes(
createZoneEventParameters.causalityToken(),
createZoneEventParameters.catalogVersion(),
- createZoneEventParameters.zoneDescriptor()
+ createZoneEventParameters.zoneDescriptor(),
+ false
).thenApply(unused -> false);
});
}
private CompletableFuture<Void>
calculateZoneAssignmentsAndCreateReplicationNodes(
long causalityToken,
int catalogVersion,
- CatalogZoneDescriptor zoneDescriptor
+ CatalogZoneDescriptor zoneDescriptor,
+ boolean nodeRecovery
Review Comment:
We already have similar methods with this parameter being called `boolean
onNodeRecovery`. I would suggest to make them all have the same name (either
your variant or the other)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
